Create a New Readerยค
When adding a new Reader to the repository the following steps should be performed.
uv is used as the package and project manager for msl-io development, it is recommended to install it. mypy and basedpyright are used as type checkers, ruff is used as the formatter/linter and the documentation is built with MkDocs using the Material theme and the mkdocstrings-python plugin. Installation of these packages is automatically managed for you by uv. CSpell provides spell checking and can be installed by running npm install -g cspell@latest (which requires Node.js and npm to be installed).
Note
If you do not want to contribute your new Reader to the repository then you only need to write the code shown in Step 2 to use your Reader in your own software. Once you import your module in your code, your Reader will be registered and it will be used to read your data files.
-
Create a fork of the repository.
-
Create a new Reader by following this template. Save it in the
src/msl/io/readersfolder.from __future__ import annotations # It's a good idea to provide type annotations in your code from typing import TYPE_CHECKING # Import the necessary msl-io object to subclass from msl.io.base import Reader if TYPE_CHECKING: from typing import Any from msl.io.types import ReadLike # Sub-classing Reader will tell msl-io that your MyReader exists class MyReader(Reader): """Name your class to be whatever you want, i.e., change MyReader.""" @staticmethod def can_read(file: ReadLike | str, **kwargs: Any) -> bool: """This method answers the following question: Given a file-like object (e.g., a file stream or a buffered reader) or a file path, can your Reader read this file? You must perform all the necessary checks that *uniquely* answers this question. For example, checking that the file extension is a particular value may not be unique enough. The optional kwargs can be passed in via the msl.io.read() function. This method must return a boolean: True (can read) or False (cannot read) """ def read(self, **kwargs: Any) -> None: """This method reads the data file(s). The optional kwargs can be passed in via the msl.io.read() function. Your Reader class is a Root object. The file to read is available at self.file To add metadata to Root use self.add_metadata() To create a Group in Root use self.create_group() To create a Dataset in Root use self.create_dataset() This method should return None. """ -
Import your Reader in the
src/msl/io/readers/__init__.pymodule. Follow what is done for the other Readers. -
Add an example data file to the
tests/samplesdirectory and add a test case to thetestsdirectory. Make sure that your Reader is returned by calling the read function, using your example data file as the input, and that the information in the returned object is correct. Run the tests usinguv run pytest. -
Lint
uv run ruff check, formatuv run ruff formatand type checkuv run basedpyright,uv run mypy .the code. These checks are also performed once you do Step 10. Type checking with mypy requires theMYPYPATH=srcenvironment variable to be defined to fix the Source file found twice under different module names: "io" and "msl.io" issue. -
Add the new Reader, alphabetically, to
docs/readers/index.md. Follow what is done for the other Readers. -
Update
CHANGELOG.mdstating that you added this new Reader. -
Build the documentation
uv run mkdocs serveand check that your Reader renders correctly. -
Run the spell checker
cspell .. Since this step requires Node.js and npm to be installed, you may skip it. This check is also performed once you do Step 10. -
If running the tests pass and linting, formatting, type/spell checking and building the documentation do not show errors/warnings then create a pull request.